Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing sources jar into published android artifacts #32982

Closed
wants to merge 1 commit into from
Closed

Add missing sources jar into published android artifacts #32982

wants to merge 1 commit into from

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Jan 27, 2022

Summary

when migrated to maven-publish in #31611, the sources jar is not included by default from maven-publish. so react-native 0.66 / 0.67 doesn't include sources jar in npm published artifacts. it's not ideal for debug or tracing code.

this pr added the sources jar into the published artifact.

Changelog

[Android] [Fixed] - Add missing sources jar into published android artifacts

Test Plan

make sure sources jar is included in artifact.

$ ./gradlew :ReactAndroid:installArchives
$ find android -name '*sources.jar*'

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 27, 2022
@react-native-bot react-native-bot added Bug Platform: Android Android applications. labels Jan 27, 2022
@Kudo
Copy link
Contributor Author

Kudo commented Jan 27, 2022

cc @dulmandakh

@analysis-bot
Copy link

analysis-bot commented Jan 27, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 20b9ed9
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,297,788 +163
android hermes armeabi-v7a 7,634,879 +149
android hermes x86 8,771,104 +193
android hermes x86_64 8,708,122 +146
android jsc arm64-v8a 9,783,593 +146
android jsc armeabi-v7a 8,768,874 +120
android jsc x86 9,749,504 +178
android jsc x86_64 10,345,405 +138

Base commit: 20b9ed9
Branch: main

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cortinico
cortinico approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great improvement, thanks for adding it 👍

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Kudo in 384e1a0.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 28, 2022
@Kudo Kudo deleted the android-add-sources-jar branch January 28, 2022 14:55
@Kudo
Copy link
Contributor Author

Kudo commented Jan 28, 2022

thanks @cortinico!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. p: Expo Partner: Expo Partner Platform: Android Android applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kudo @analysis-bot @facebook-github-bot @react-native-bot @cortinico